Task statuses and problems don't restore after reload

[meganrogge]

#155120 (comment)

[meganrogge]

also reported here #155163

[meganrogge]

happening bc there's no problem matcher on the configurationProperties

[meganrogge]

actually, this is now working - I was just seeing the strange issue in which my VS Code build task doesn't work. @Tyriar could you pls confirm statuses work after reload for the VS Code build task in today's insider's?

status.mov

[Tyriar]

@meganrogge I see a spinners when I reload on Windows:

Probably also something that needs #152634

[meganrogge]

yeah @Tyriar if you make a change and save, it'll update the status. before that wasn't happening, which is the bug I'd like help verifying is fixed. works for xterm.js for me

[meganrogge]

actually I think it shouldn't be spinning on reload since we will know the status it should have initially. i'll investigate

[Tyriar]

This is a little hard to solve actually, note that active problems are also not restored. When reconnecting to the terminal we restore the buffer using initialText which doesn't end up firing onLineData. We also shouldn't be persisting the status on the pty host because consider the following:

• Fail build, status syncs to pty host
• Restart
• Pass build during restart
• We would restore the fail status here if we persisted to the pty host.

We handle the above problem for shell integration by running shell integration in parallel also on the pty host, we wouldn't want to do that with tasks as it would be too expensive and we also don't have the infrastructure set up for that.

I think the fix here should be similar to #152634, there should be some mechanism in tasks that allows scanning up to find certain patterns. For #152634 we want to scan up a few lines in the buffer and to re-evaluate endsPattern if possible, for this issue we want to scan up a reasonable amount on reconnect to find a beginsPattern and reparse that and all lines after to activate statuses and problem matchers.

I'm going to move this to August as the fix is a little too involved for me to tackle atm. It's a little annoying but it's also easily worked around (save a change).