Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare property quick fix incorrectly escapes $ #152272

Closed
mjbvz opened this issue Jun 16, 2022 · 4 comments · Fixed by #152350
Closed

Declare property quick fix incorrectly escapes $ #152272

mjbvz opened this issue Jun 16, 2022 · 4 comments · Fixed by #152350
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 16, 2022

Issue Type: Bug

For the ts:

class Foo {
    bar() { 
        this.$prop 
    }
}
  1. Trigger declare property on this.$prop

Bug:
\$prop is inserted instead of just $prop

class Foo {
    \$prop: any;
    bar() { 
        this.$prop
    }
}

VS Code version: Code - Insiders 1.69.0-insider (Universal) (0b74e15, 2022-06-15T05:20:12.417Z)
OS version: Darwin x64 21.5.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 2, 2
Memory (System) 32.00GB (0.25GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 16, 2022

@jrieken I believe this may be caused by the workspace snippet edit work. Here's how we build up the edit:

I confirmed that the incoming text does not have the \

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 16, 2022
@mjbvz mjbvz added this to the June 2022 milestone Jun 16, 2022
@ghost
Copy link

ghost commented Jun 16, 2022

also adds slash on save
to get around this save without formatting ctrl +k ctrl + shft +s
I assume this is only on the insiders version
image

mjbvz added a commit to mjbvz/vscode that referenced this issue Jun 16, 2022
mjbvz added a commit that referenced this issue Jun 16, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 16, 2022
justschen pushed a commit to justschen/vscode that referenced this issue Jun 16, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 17, 2022
@ghost
Copy link

ghost commented Jun 17, 2022

this has been fixed in the code editor but still remains an issue in the working tree view (git)

image

@JonWallsten
Copy link

JonWallsten commented Jun 21, 2022

@mjbvz: The extra slash is still added to import lines in latest VSCode Insiders. Not at the same frequency as before. But once every 5-10 minutes or so.

Edit: It seems related to Save all/Multiple files. If I change something in File A and then go to File B and use Ctrl+K S File A gets extra slashes.

@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants