Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal find: text should not render with overflow elipses #148142

Closed
isidorn opened this issue Apr 26, 2022 · 0 comments · Fixed by #148306
Closed

Terminal find: text should not render with overflow elipses #148142

isidorn opened this issue Apr 26, 2022 · 0 comments · Fixed by #148306
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-find Relating the terminal's find widget verified Verification succeeded
Milestone
April 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2022

Testing #148060

Have some long text in the terminal find input, notice how the ... is rendered when the input box has no focus. When the input box gets focus the ... is not rendered.
Now notice the editor ... is never rendered which is the correct behaviour imho

They should be consistent.

Screenshot 2022-04-26 at 13 51 47
Screenshot 2022-04-26 at 13 51 56
@meganrogge meganrogge added polish Cleanup and polish issue terminal-find Relating the terminal's find widget labels Apr 26, 2022
@meganrogge meganrogge modified the milestones: May 2022, April 2022 Apr 26, 2022
meganrogge added a commit that referenced this issue Apr 27, 2022
@meganrogge
fix #148142
c047ddf
@meganrogge meganrogge mentioned this issue Apr 27, 2022
Merged
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2022
@amunger amunger added the verified Verification succeeded label Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-find Relating the terminal's find widget verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

improve consistency of terminal find with editor find microsoft/vscode
5 participants
@isidorn @amunger @Tyriar @meganrogge and others