Terminal find match count is incorrect

[joyceerhl]

Testing #148060

1. Create a new terminal
2. Run a script which logs the same text 2000 times
3. Run a query, ✅ find widget says there are 2000 matches
4. Resize the terminal (e.g. collapse and expand the side bar)
5. 🐛 the number of matches is now less even though the same amount of scrollback is visible, moreover deleting and reentering the query doesn't reset the match count

[rchiodo]

Maybe this isn't released yet, but I'm still getting the same problem in today's insiders.

[joyceerhl]

Still repros for me :(

[meganrogge]

Can one of you pls provide a gif? it's working for me with the above example as expected and with others

[meganrogge]

search.mov

[meganrogge]

You are both on Windows - I wonder if that has to do with this. Could someone on mac pls verify this?

[joyceerhl]

[meganrogge]

from @joyceerhl

[Tyriar]

Something weird going on here:

This is after pasting in " Hi Hi" many times, once the command wraps to the end the terminal freaks out (conpty reprinting), but at some point it breaks and find only finds one result. Finding the next works, but it still says 1 of 1.

[Tyriar]

More weird behavior

[Tyriar]

All results aren't getting included when search results get highlighted

[Tyriar]

Problem here seems to be the search addon gets confused because translateToString considers the second character whitespace:

https://github.com/xtermjs/xterm.js/blob/fd5f5e3204843263c13bda850502d1d77be2b3e5/src/common/buffer/BufferLine.ts#L436

But in the search algorirthm it's treated as a null character, '' of length 0, as opposed to ' '.

[joyceerhl]

Still reproing this. Initially:

After making the terminal panel taller:

[Tyriar]

@joyceerhl this is on Windows? That's actually acting as expected because of the way conpty works, it ends up losing lines just above the bottom of the buffer.

[Tyriar]

Pretty sure you were seeing #150886 so closing this again for verification