Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline suggestions are jumping #145586

Closed
alexdima opened this issue Mar 21, 2022 · 2 comments
Closed

Inline suggestions are jumping #145586

alexdima opened this issue Mar 21, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Mar 21, 2022

Using:

"editor.quickSuggestions": {
  "other": "inline",
  "comments": "inline",
  "strings": "inline"
}
  • Type something to get suggestions
  • Do drag and drop to select some characters
Kapture.2022-03-21.at.17.58.06.mp4
@jrieken
Copy link
Member

jrieken commented Mar 22, 2022

I see two things:

  • while inline completions are re-requested the strikeout shows
  • inline completions are showing in-between words. That's something we don't do with "normal" quick suggest

I can push a change to show inline quick suggestion at word ends only but it raises if inline completions should trigger in-between words at all or iff so if they should have more strict rules.

@jrieken jrieken added this to the March 2022 milestone Mar 22, 2022
@jrieken jrieken added suggest IntelliSense, Auto Complete inline-completions labels Mar 22, 2022
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 23, 2022
@jrieken
Copy link
Member

jrieken commented Mar 23, 2022

I have pushed a change that enables inline quick suggestion only when typing at word ends. That's aligns this with "normal" quick suggestions and should feel less nervous

@jrieken jrieken closed this as completed Mar 23, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants