Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play sound upon completion of build so that users can multi-task (do work in other applications) and know when the build has completed #141506

Closed
dabelt-msft opened this issue Jan 25, 2022 · 8 comments · Fixed by #160828
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@dabelt-msft
Copy link

I see others have requested the ability to play a sound upon the completion of a build. This request was duplicated seemingly erroneously here (#12466) because visual indication of build status was provided in the terminal; but visual indication requires that people stick around to watch the build or check back frequently, breaking concentration. Enabling a user to toggle an audible indication of a build failure or completion increases the ability to multitask.

@dabelt-msft dabelt-msft changed the title Play sound upon completion of build so that users can multi-task (do work in other tabs) and know when the build has completed Play sound upon completion of build so that users can multi-task (do work in other applications) and know when the build has completed Jan 25, 2022
@meganrogge meganrogge assigned alexr00 and unassigned meganrogge Jan 26, 2022
@alexr00 alexr00 added feature-request Request for new features or functionality tasks Task system issues labels Jan 27, 2022
@alexr00 alexr00 added this to the Backlog Candidates milestone Jan 27, 2022
@diminutivesloop
Copy link
Contributor

Ideally this would also support visual notification such as OS notifications for situations where an audible notification won't be heard such as deafness or muted speakers.

@alexr00 alexr00 modified the milestones: Backlog Candidates, Backlog Mar 29, 2022
@alexr00 alexr00 reopened this Mar 29, 2022
@meganrogge meganrogge self-assigned this Jun 13, 2022
@alexr00 alexr00 removed their assignment Jun 30, 2022
@meganrogge meganrogge modified the milestones: Backlog, September 2022 Aug 15, 2022
@isidorn
Copy link
Contributor

isidorn commented Aug 15, 2022

Our sound designer create a sound for this, so we can start on the implementation in September.
In addition to the completion sound, the designer created a sound for when the task started. I am not 100% convinced we need this sound. So I suggest we start just with the "task finished" sound. But I am open to suggestions.

@Tyriar Tyriar added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Aug 30, 2022
@dabelt-msft
Copy link
Author

Regarding the sound to indicate the process started - I agree that it doesn't seem necessary, and I would go further to say that some people might dislike it. If implemented would be good to have an option to toggle both independently because my guess is most people would only want the completion sound. Otherwise it could be annoying to have too many sounds, some of which are unnecessary.

@isidorn
Copy link
Contributor

isidorn commented Aug 31, 2022

@dabelt-msft I agree.
@meganrogge maybe we start with just a "task finished" sound. Do let me know if I can help here. Thanks!

fyi @AFre100

@bmartin
Copy link

bmartin commented Aug 31, 2022 via email

meganrogge added a commit that referenced this issue Sep 13, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 15, 2022
@meganrogge meganrogge added the verification-needed Verification of issue is requested label Sep 26, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants