Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language status item doesn't appear when language mode is set #140589

Closed
karrtikr opened this issue Jan 12, 2022 · 0 comments
Closed

Language status item doesn't appear when language mode is set #140589

karrtikr opened this issue Jan 12, 2022 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Jan 12, 2022

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.64.0-insider (user setup)
  • OS Version: Windows_NT x64 10.0.22518

Steps to Reproduce:

  1. Create a untitled file.
  2. Select a language mode.
  3. Language status items for that language do not appear.
  4. Open another untitled file and go back to the original file.
  5. Language status items now start appearing.

Here's a GIF to describe the process:

This is currently a major blocker for us in adapting the new language status API: microsoft/vscode-python#18040, as we have a getting started experience where we teach the user to create an untitled file and then select an interpreter using the status bar, which will not be possible without this bug fix.

The bug is probably somewhere around

this._onDidRemoveDocument.fire(data.document);
data._acceptLanguageId(newLanguageId);
this._onDidAddDocument.fire(data.document);
where we miss to fire a language status item event when we set a language mode.

cc @isidorn

@jrieken jrieken assigned jrieken and unassigned joaomoreno Jan 13, 2022
@jrieken jrieken added this to the January 2022 milestone Jan 13, 2022
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jan 13, 2022
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 14, 2022
Commit: 6cbbb83419c8353906b1de9acc20b0d576665d32
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @IanMatthewHuff @jrieken @karrtikr and others