Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No default profile" exception when creating a new terminal if default setting is null #136362

Closed
Tyriar opened this issue Nov 3, 2021 · 1 comment · Fixed by #136438
Closed

"No default profile" exception when creating a new terminal if default setting is null #136362

Tyriar opened this issue Nov 3, 2021 · 1 comment · Fixed by #136438
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-profiles verified Verification succeeded
Milestone
November 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 3, 2021

On split of ctrl+shift+`, clicking the + silently fails:

image

This should be <string | null> or <unknown>:

vscode/src/vs/workbench/contrib/terminal/browser/terminalProfileService.ts

Line 145 in 2c39062

this._defaultProfileName = this._configurationService.getValue(`${TerminalSettingPrefix.DefaultProfile}${platform}`);

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority terminal-profiles labels Nov 3, 2021
@Tyriar Tyriar added this to the November 2021 milestone Nov 3, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Nov 4, 2021

The error is probably fixed, but let's make that getValue call return the expected <string | null> and fix any compile errors (ie. it's null not undefined)

@Tyriar Tyriar reopened this Nov 4, 2021
meganrogge added a commit that referenced this issue Nov 4, 2021
@meganrogge
fix #136362
192768d
@meganrogge meganrogge mentioned this issue Nov 4, 2021
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-profiles verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

if profile name is null return undefined microsoft/vscode
5 participants
@Tyriar @rzhao271 @meganrogge and others