vscode.env.openExternal double encodes the data if you pass a param in the query that also requires encoding #135949
Labels
bug
Issue identified by VS Code Team member as probable bug
*duplicate
Issue identified as a duplicate of another issue(s)
help wanted
Issues identified as good community contribution opportunities
uri
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
I have the following code in a VSC extension:
When
vscode.env.openExternal
is executed this messes up with the proper encoding of the URL query params and the browser is opened to a URL like:http://localhost:3000/?callbackUri=vscode://hello.vsc-develop/callback%253FwindowId%253D13&test=ok
Notice how the
?
and=
are encoded twice (%253F
,%253D13
)I would expect callbackUri to be encoded as
vscode%3A%2F%2Fhello.vsc-develop%2Fcallback%3FwindowId%3D13
as that how encodeURIComponent encodes it.So two questions here:
://
and/
parts also encoded byvscode.Uri.parse
+vscode.env.openExternal
??
and=
characters encoded twice?The text was updated successfully, but these errors were encountered: