Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading lock icon in empty groups #131586

Closed
sbatten opened this issue Aug 24, 2021 · 2 comments
Closed

Misleading lock icon in empty groups #131586

sbatten opened this issue Aug 24, 2021 · 2 comments
Assignees
@bpasero
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-groups Issues related to editor groups
Milestone
August 2021

Comments

@sbatten
Copy link
Member

sbatten commented Aug 24, 2021

Testing #131196

By replacing the X icon in empty groups, I tend to believe that this lock protects the empty group from closing, but this is an unrelated feature.
@bpasero bpasero added the workbench-editor-groups Issues related to editor groups label Aug 25, 2021
@bpasero bpasero added this to the August 2021 milestone Aug 25, 2021
@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

Did this for a leaner look, but agree it is a bit misleading.

@bpasero bpasero added polish Cleanup and polish issue bug Issue identified by VS Code Team member as probable bug labels Aug 25, 2021
@bpasero bpasero added verification-needed Verification of issue is requested and removed bug Issue identified by VS Code Team member as probable bug labels Aug 25, 2021
@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

Verification:

  • open 2x2 editor layout
  • lock one of the empty groups from the context menu
  • verify the lock icon appears next to the close icon

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 25, 2021
JacksonKearl pushed a commit that referenced this issue Aug 25, 2021
@bpasero
Misleading lock icon in empty groups (fix #131586)
b7b5ff6
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-groups Issues related to editor groups
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
4 participants
@bpasero @sbatten @rzhao271 and others