Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locked groups: inactive tab creates empty group #131557

Closed
sbatten opened this issue Aug 24, 2021 · 2 comments
Closed

Locked groups: inactive tab creates empty group #131557

sbatten opened this issue Aug 24, 2021 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editor-groups Issues related to editor groups
Milestone
August 2021

Comments

@sbatten
Copy link
Member

sbatten commented Aug 24, 2021

Testing #131196

Opening a file from the explorer that is already an inactive tab in a locked group activates the tab but also creates an empty group.

recording (1)
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editor-groups Issues related to editor groups labels Aug 25, 2021
@bpasero bpasero added this to the August 2021 milestone Aug 25, 2021
@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

That sounds like a bug to me and not intended behaviour.

@bpasero bpasero changed the title Inactive tab creates empty group Locked groups: inactive tab creates empty group Aug 25, 2021
@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

Steps:

  • enable workbench.editor.revealIfOpen: true
  • build up a group and editor layout like Steven has, all groups are locked
  • try to reproduce by clicking on a file in the explorer that is inactive

JacksonKearl pushed a commit that referenced this issue Aug 25, 2021
@bpasero
Locked groups: inactive tab creates empty group (fix #131557)
45a2d28
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editor-groups Issues related to editor groups
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
4 participants
@bpasero @sbatten @rzhao271 and others