Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked group: workbench.editor.experimentalAutoLockGroups doesn't mention that value is an array of editor types #131528

Closed
aeschli opened this issue Aug 24, 2021 · 2 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-editor-groups Issues related to editor groups
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 24, 2021

Testing #131196

The test item asked if the description of workbench.editor.experimentalAutoLockGroups is understandable.

Experimental: lock a group automatically when an editor is the first in the group and more than one 
group is open. Locked groups will only be used for opening editors when explicitly chosen by user
gesture (e.g. drag and drop), but not by default. Consequently the active editor in a locked group is
less likely to be replaced accidentally with a different editor.
	"workbench.editor.experimentalAutoLockGroups": [
		"workbench.editors.terminal"
	]

What I'm missing is the description what the values are.
I think it might be easier to start with the value:

If an editor of the listed types is opened as the first in an editor group, the group is automatically locked. 
Locked groups are not used when new editors ar opened unless explicitly chosen by user 
gesture (e.g. drag and drop).

But I wonder is such a general setting is really needed. There could be a terminal specific setting that is easier to understand.

Open terminals in editor area to the side in locked groups

@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

We have #131587 to offer help in filling in the possible values.

As for a terminal specific setting: that is what I had first, but then others expressed interest in being able to use auto-locking for other editors like markdown preview where it makes sense too.

Moving to August to review the wording of the setting based on your suggestion.

@bpasero bpasero added this to the August 2021 milestone Aug 25, 2021
@bpasero bpasero added the workbench-editor-groups Issues related to editor groups label Aug 25, 2021
@bpasero bpasero changed the title workbench.editor.experimentalAutoLockGroups doesn't mention that value is an array of editor types Locked group: workbench.editor.experimentalAutoLockGroups doesn't mention that value is an array of editor types Aug 25, 2021
@bpasero bpasero added the polish Cleanup and polish issue label Aug 25, 2021
@bpasero
Copy link
Member

bpasero commented Aug 25, 2021

Changed the first sentence of the settings description to:

Experimental: If an editor matching one of the listed types is opened as the first in an editor group and more than one group is open, the group is automatically locked.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-editor-groups Issues related to editor groups
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @aeschli and others