-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore ways to show execution progress while the execute cell is out of the viewport #130611
Comments
All sound good to me except the 'Go to running cell'. Maybe I'm misunderstanding that one though. Is that only available when actually running? |
@rchiodo yes, this is for the case where users may not see the status bar item and having an extra item added there. I'm unsure if this is the best place as the toolbar is pretty busy and things overflow. But it was worth adding there. |
One additional idea that @jilljac mentioned was that it would be cool if when the user clicks on the |
That notification idea is something that customers have requested before. I believe at least one customer even wanted like a toast notification in Windows so they could bop back to VS Code when their notebook was done running. Might be more of an opt in feature though, hate to add new popups if we can help it. Status bar is very commonly missed by customers, but it's also quick, non-noisy and easy fix, so I like that as one option. Also kinda like making the kernel picker running icon clickable. I'm not sure if that is a place that I'd normally expect a click affordance, but it makes sense to me conceptually without wasting more toolbar real estate. |
+1 for go to running cell. I struggled with this when I was working with large notebooks. |
Another idea from @tanhakabir is to show the editor progress bar when a cell is running. Will be good to test to see how this looks with the cell running cell or if we can show one at a time. @rchiodo also suggested we could switch to only showing the editor progress bar and remove the in-cell progress bar |
Not sure if there has been final resolution here, but I think having a goto running cell affordance would be very much appreciated by many. I like the idea of replacing the kernel icon with the "running" icon. This is very similar to how Jupyter and Jupyter Lab display running state globally (I think collab too?) I'm going to throw this possibly crazy idea out there too. What if the scrolling blue progress bar could essentially "follow the direction" the executing cell? Normally the cell itself would show the running status like it does today, but if the top of it scrolls above the current view, then the progress bar becomes "stuck" to the top of the viewport. If the top of the running cell scrolls off the bottom of the view, then the progress bar becomes "stuck" to the bottom of the viewport. This would give an indication of which way to scroll to see the running cell. Alternatively clicking on the "goto running cell" button mentioned above would go right there. |
+1 to have the notebook "follow" the active running cell, that is captured in #107919 and would be great to fold into this work |
Here's what I'm proposing we start with:
CleanShot.2021-09-13.at.14.35.04.mp4 |
Looks good and I really like the outline view affordance, but there's a couple of concerns:
The "crazy" proposal I had suggested in the issue wasn't about following the executing cell in the sense of automatically scrolling the view to it (though that is still an interesting concept). What I was referring to was having the scrolling progress bar always appear in one of 3 places.
|
Ideally near the status bar/output is what I had imagined as most likely want to see the results?
This is one is tough as someone who disables this is really missing other information (status, language, etc.) we could add an asterisk to the execution count as an alternate indicator
Good point, I hadn't considered this. Will mock this version out. |
Here's the latest update from feedback. Added the per-cell progress and moved it to the editor when it is out of view and updated the toolbar actions to reflect the "Interrupt" and "Go to cell" contextual actions: CleanShot.2021-09-14.at.16.21.42.mp4And here's an example for a collapse cell w/ progress and showing the execution count: CleanShot.2021-09-14.at.16.22.33.mp4 |
That looks awesome! |
On the iteration plan for Nov, so making it part of the November milestone. |
To summarize
Is showing the execution count for a collapsed cell part of this? |
Summary
When running a notebook that has a lot of cells, it can be hard to keep track of where the currently executing cell is. It becomes harder when the currently running cell is out of the viewport, so the user has to scan to notebook to find the correct one. See example below, where is the running cell?
Concepts
These are all a collection of different ideas that I've explored. We can combine some of these different ideas together or treat them as separate items.
Status bar item
A simple option would be to add a status bar item that says
Running cell XX (8.2s)
and clicking on it would take you to the running cell:Adding indicators
In addition to this, we could also add indicators in the outline view and editor tab. This is helpful for when you have the outline view open or you are on a different tab and want to know if a notebook is still running.
Adding item in notebook toolbar
We could also add an action in the toolbar that will take you directly there, though we have to battle with the other actions to make this visible:
Alternatively, we could turn the kernel picker into a split action that and change the icon of the kernel into progress:
Notifications
For the cases where a notebook can take a while longer (+1min) we could look into showing a notification if the user has focus somewhere else (like anther notebook)
The text was updated successfully, but these errors were encountered: