Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating the GUI settings editor #129594

Closed
NatoBoram opened this issue Jul 27, 2021 · 4 comments
Closed

Consider deprecating the GUI settings editor #129594

NatoBoram opened this issue Jul 27, 2021 · 4 comments
Assignees

Comments

@NatoBoram
Copy link

NatoBoram commented Jul 27, 2021

Now that the 3 issues about removing the split JSON settings editor (🔒 #62964, 🔒 #64932, 🔒 #125952, 206 👎) are part of the top 25 most downvoted issues of VSCode, you should consider getting rid of the GUI settings editor. It would not only mean less code to maintain and new UX feature investment can be focused on the text editing experience of the text editor, but it would also tackle the perceived myth that the split JSON settings editor is a hindrance or is unfriendly to newer users.

Keeping this GUI around for a long time is not free and leads to a trail of tech debt that costs developer time that could be spent improving other areas of VSCode. It also represents many lines of code, and as the complexity and download size of VS Code grows, available opportunities should be taken to reduce it.

By default, workbench.settings.useSplitJSON should be changed to true in order to assess how many users just use the default settings versus how many actually choose their preferred settings editing experience. This is important because default choice matter.

In addition, improvements should be made to the rest of the editors to better support key-value languages in such a way that the current settings editor would be made redundant. Instead of alienating users like removing the settings editor does, these changes would empower everyone not only when editing settings, but also in all scenarios where key-value languages are used, such as i18n files.

  • Fuzzy search
  • Hiding keys that aren't found by the search feature
  • Searching in one panel should optionally search other panels, too
  • Selecting a key in one panel should focus on that key on other panels
  • The little pencil icon's "copy to settings" should be replaced by "copy to other panes"
@daiyam
Copy link
Contributor

daiyam commented Aug 14, 2021

Here the patch to add back the previous JSON settings editor: json-settings-editor.patch.zip

I've just copied the old version from 1.58 and fixed the few changes...

@carlocardella
Copy link
Member

🤣

@NatoBoram
Copy link
Author

Yeah let me just create 2 new issues about this since, apparently, third time's the charm.

@wenfangdu
Copy link
Contributor

A feature request for improving the GUI settings editor: #131390.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants