Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json settings editor #794

Closed
OneOfOne opened this issue Aug 9, 2021 · 12 comments
Closed

json settings editor #794

OneOfOne opened this issue Aug 9, 2021 · 12 comments
Labels
discussion could go either way, discussion welcome

Comments

@OneOfOne
Copy link

OneOfOne commented Aug 9, 2021

With microsoft completely ignoring the voices of the community (shocking, right?), is there any chance you guys can revert that horrible bug they introduced?

microsoft/vscode#125952

@OneOfOne OneOfOne added the bug Something isn't working label Aug 9, 2021
@daiyam
Copy link
Member

daiyam commented Aug 9, 2021

Damn! I've really thought that the split had removed few months back!! I just found that it's option to check. No wonder that it is used very little... By the way, I'm editing the setting in JSON.

I will have to understand why it has been deprecated and removed in the first place.
When I've started using VSCode, I did like that feature and thought that it was nice.

In the meantimes, you are welcome to make a PR.

@daiyam
Copy link
Member

daiyam commented Aug 9, 2021

The old split JSON settings editor is more useful because when searching, the unmatched properties are hidden.

I think the split JSON settings editor should be the default, like 2-3 years ago. The GUI isn't very useful...

I've read the post, no real information about the tech limitation...

@carlocardella
Copy link

carlocardella commented Aug 9, 2021

You might want to upvote this issue (not sure it will make any difference but we can try): microsoft/vscode#129594

@daiyam
Copy link
Member

daiyam commented Aug 14, 2021

Here the patch to add back the previous JSON settings editor: json-settings-editor.patch.zip

I've just copied the old version from 1.58 and fixed the few changes...

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, and we'll keep it open. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the stale label Oct 8, 2022
@lonix1
Copy link

lonix1 commented Oct 8, 2022

!stale

@daiyam daiyam added discussion could go either way, discussion welcome and removed bug Something isn't working stale labels Oct 8, 2022
@Crystal-RainSlide
Copy link
Contributor

Crystal-RainSlide commented Oct 24, 2022

To just access the JSON settings:
F1 or Ctrl + Shift + P, then:

  • > Preferences: Open User Settings (JSON)
  • > Preferences: Open Default Settings (JSON)
  • ...

To write a extension and add some buttons, here are the commands:

  • Default Settings (JSON): workbench.action.openRawDefaultSettings
  • Folder Settings (JSON): workbench.action.openFolderSettingsFile
  • Workspace Settings (JSON): workbench.action.openWorkspaceSettingsFile
  • Remote Settings (JSON): workbench.action.openRemoteSettingsFile
  • User Settings (JSON), not sure why there are 2 of them:
    • workbench.action.openSettingsJson
    • workbench.action.openApplicationSettingsJson

@daiyam
Copy link
Member

daiyam commented Oct 24, 2022

I don't think we will re-implement the JSON settings editor. It will take too much time.

@Crystal-RainSlide It was when the JSON settings editor was a split editor between the current editor and the reference file with sync search and other....

@daiyam daiyam closed this as completed Oct 24, 2022
@lonix1
Copy link

lonix1 commented Oct 24, 2022

😭

@Crystal-RainSlide
Copy link
Contributor

hmmm

workbench.settings.useSplitJSON

hmmm

@daiyam
Copy link
Member

daiyam commented Oct 24, 2022

@lonix1 Ya... Sorry Me too, I'm sad.
@Crystal-RainSlide No, not the same... The old one was 1 editor with 1 search. The new is 2 editors with 2 searchs.

@Crystal-RainSlide
Copy link
Contributor

Crystal-RainSlide commented Oct 26, 2022

hmmm (*2)

This one don't seems like started though

https://github.com/zokugun/MrCode#split-json-settings-editor

split JSON settings editor

I will try to add back the split JSON settings editor via an extension.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion could go either way, discussion welcome
Projects
None yet
Development

No branches or pull requests

5 participants