Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal editors should be marked as dirty when the shell has child processes #127193

Closed
Tyriar opened this issue Jun 25, 2021 · 0 comments · Fixed by #128739
Closed

Terminal editors should be marked as dirty when the shell has child processes #127193

Tyriar opened this issue Jun 25, 2021 · 0 comments · Fixed by #128739
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label terminal-editors
Milestone
July 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2021

This will help accidental ctrl/cmd+w's being less destructive. It could also be extended to regular terminals and driven by a setting.

Related: #23808
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-editors labels Jun 25, 2021
@Tyriar Tyriar added this to the July 2021 milestone Jun 25, 2021
@Tyriar Tyriar mentioned this issue Jun 25, 2021
Closed
27 tasks
@meganrogge meganrogge mentioned this issue Jul 9, 2021
Closed
This was referenced Jul 11, 2021
Closed
Closed
Tyriar added a commit that referenced this issue Jul 15, 2021
@Tyriar
Create child process monitor
a0f8867 
Part of #23808
Part of #127193
@Tyriar Tyriar mentioned this issue Jul 15, 2021
Merged
@meganrogge meganrogge mentioned this issue Jul 26, 2021
Closed
3 tasks
@Tyriar Tyriar mentioned this issue Aug 27, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label terminal-editors
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Monitor terminal process child processes microsoft/vscode
3 participants
@Tyriar @meganrogge and others