Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Editors: Support transferring terminal processes to/from editors #126243

Closed
Tyriar opened this issue Jun 14, 2021 · 2 comments · Fixed by #126674
Closed

Terminal Editors: Support transferring terminal processes to/from editors #126243

Tyriar opened this issue Jun 14, 2021 · 2 comments · Fixed by #126674
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-editors
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2021

Sub-task of #125514

This will manage instances and whether they are in the panel or editor.
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-tabs labels Jun 14, 2021
@Tyriar Tyriar added this to the June 2021 milestone Jun 14, 2021
This was referenced Jun 14, 2021
Closed
Closed
@Tyriar Tyriar changed the title Create TerminalGroupService Terminal Editors: Create TerminalGroupService Jun 14, 2021
@Tyriar Tyriar changed the title Terminal Editors: Create TerminalGroupService Terminal Editors: Support transferring terminal processes to/from editors Jun 14, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Jun 14, 2021 •
edited
Loading

  • Consider how this affects extension host API events - need onProcessDetach?
  • Attach command is slow to query, should support an arg to connect to a terminal immediately if it's available
  • Transferring ownership would be faster than detach + reattach
  • Align command naming detach/attach session/process

@Tyriar Tyriar mentioned this issue Jun 15, 2021
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jun 16, 2021

Plan

Screen Shot 2021-06-16 at 10 09 32 AM

Tyriar added a commit that referenced this issue Jun 18, 2021
@Tyriar
Create group service
4cac8a8 
Part of #126243
@Tyriar Tyriar mentioned this issue Jun 18, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal General terminal issues that don't fall under another label terminal-editors
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Create terminal group service microsoft/vscode
3 participants
@Tyriar @meganrogge and others