Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto Symbol doesn't show all functions defined inside the file. #125

Closed
trash opened this issue Nov 18, 2015 · 5 comments
Closed

Goto Symbol doesn't show all functions defined inside the file. #125

trash opened this issue Nov 18, 2015 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues
Milestone

Comments

@trash
Copy link

trash commented Nov 18, 2015

Using "Go To Symbol..." (⇧⌘O) it seems to only recognize certain ways of declaring functions in javascript.

screen shot 2015-11-18 at 5 49 37 pm

All three functions should show up when you search "searchable", right? Only "searchable" and "alsoSearchable" show up however.

In this case it looks like these cases work:

  1. Anonymous function assigned as a property on and object when the object is instantiated.
  2. Named function assigned as a property on an object after it's instantiated.

And this case doesn't work:

  1. Anonymous function assigned as a property on an object after it's already been instantiated.

This works in Sublime Text and I'd love if it could work in VS Code as well as it's one of the main ways I navigate my javascript code (especially the thousands of lines of code for my game).

@egamma egamma modified the milestone: Backlog Dec 10, 2015
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues labels Dec 22, 2015
@yupal
Copy link

yupal commented Feb 10, 2016

This issue is present in this case too:
When I have a function defined as
var testFunction = function() {}

Here is a screenshot with the issue:
http://imgur.com/wS66ROM

@egamma
Copy link
Member

egamma commented Feb 10, 2016

Can you please try to reproduce using the new Salsa JS infrastructure: https://code.visualstudio.com/updates/#_javascript-salsa-preview

@yupal
Copy link

yupal commented Feb 10, 2016

Using Salsa JS on the same example as I wrote before I get IntelliSense knowing the function, but now when I try to go to symbol I got no suggestion ( the go to symbol ( @ ) returns an empty list ).

@egamma
Copy link
Member

egamma commented Feb 10, 2016

Moving to salsa for investigation

@egamma egamma changed the title Incomplete symbol recognition for functions in javascript Goto Symbol doesn't show all functions defined inside the file. Feb 10, 2016
@egamma
Copy link
Member

egamma commented Feb 10, 2016

This issue was moved to microsoft/TypeScript#7003

@egamma egamma closed this as completed Feb 10, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

4 participants