Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto Symbol doesn't show all functions defined inside the file. #7003

Closed
egamma opened this issue Feb 10, 2016 · 5 comments
Closed

Goto Symbol doesn't show all functions defined inside the file. #7003

egamma opened this issue Feb 10, 2016 · 5 comments
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created

Comments

@egamma
Copy link
Member

egamma commented Feb 10, 2016

From @khalilravanna on November 18, 2015 23:54

Using "Go To Symbol..." (⇧⌘O) it seems to only recognize certain ways of declaring functions in javascript.

screen shot 2015-11-18 at 5 49 37 pm

All three functions should show up when you search "searchable", right? Only "searchable" and "alsoSearchable" show up however.

In this case it looks like these cases work:

  1. Anonymous function assigned as a property on and object when the object is instantiated.
  2. Named function assigned as a property on an object after it's instantiated.

And this case doesn't work:

  1. Anonymous function assigned as a property on an object after it's already been instantiated.

This works in Sublime Text and I'd love if it could work in VS Code as well as it's one of the main ways I navigate my javascript code (especially the thousands of lines of code for my game).

Copied from original issue: microsoft/vscode#125

@egamma
Copy link
Member Author

egamma commented Feb 10, 2016

From @yupal on February 10, 2016 10:31

This issue is present in this case too:
When I have a function defined as
var testFunction = function() {}

Here is a screenshot with the issue:
http://imgur.com/wS66ROM

@egamma egamma added Bug A bug in TypeScript js labels Feb 10, 2016
@egamma
Copy link
Member Author

egamma commented Feb 10, 2016

Can you please try to reproduce using the new Salsa JS infrastructure: https://code.visualstudio.com/updates/#_javascript-salsa-preview

@egamma
Copy link
Member Author

egamma commented Feb 10, 2016

From @yupal on February 10, 2016 12:17

Using Salsa JS on the same example as I wrote before I get IntelliSense knowing the function, but now when I try to go to symbol I got no suggestion ( the go to symbol ( @ ) returns an empty list ).

@egamma
Copy link
Member Author

egamma commented Feb 10, 2016

Moving to salsa for investigation

@mhegazy
Copy link
Contributor

mhegazy commented Feb 10, 2016

same root cause as #6828.

@mhegazy mhegazy closed this as completed Feb 10, 2016
@mhegazy mhegazy added Duplicate An existing issue was already created and removed js labels Feb 10, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants