Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting colors in terminal profile setting #123829

Closed
Tyriar opened this issue May 13, 2021 · 5 comments · Fixed by #124511
Closed

Support setting colors in terminal profile setting #123829

Tyriar opened this issue May 13, 2021 · 5 comments · Fixed by #124511
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Milestone
May 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented May 13, 2021

Follow up from #121738
@Tyriar Tyriar added feature-request Request for new features or functionality polish Cleanup and polish issue terminal General terminal issues that don't fall under another label labels May 13, 2021
@Tyriar Tyriar added this to the May 2021 milestone May 13, 2021
@meganrogge
Copy link
Contributor

How will these interact w the icon -

will we support setting a profile's icon to a ThemeIcon | URI | { light: URI, dark: URI }?

@Stirfry70

This comment has been minimized.

Sign in to view
@Stirfry70

This comment has been minimized.

Sign in to view
@Tyriar
Copy link
Member Author

Tyriar commented May 17, 2021 •
edited
Loading

I think for the profile setting we'll probably just have color: 'terminal.ansiRed' | 'terminal.ansiBlack' | ...

@Tyriar
Copy link
Member Author

Tyriar commented May 21, 2021

To support any color we would need to move the below into TerminalView's style tag:

https://github.com/Microsoft/vscode/blob/514d3162bc82bc9bc50c4aba0992f1386ad3d3d4/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1953-L1960

Tyriar added a commit that referenced this issue May 24, 2021
@Tyriar
Support colors in terminal profile setting
9eaba89 
Fixes #123829
@Tyriar Tyriar mentioned this issue May 24, 2021
Merged
bpasero pushed a commit to bpasero/vscode that referenced this issue May 25, 2021
@Tyriar @bpasero
Support colors in terminal profile setting
c6970e6 
Fixes microsoft#123829
Ashray123 pushed a commit to Ashray123/vscode that referenced this issue May 25, 2021
@Tyriar @Ashray123
Support colors in terminal profile setting
4300875 
Fixes microsoft#123829
@Tyriar Tyriar added on-testplan on-release-notes Issue/pull request mentioned in release notes labels May 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan polish Cleanup and polish issue terminal General terminal issues that don't fall under another label terminal-tabs
Projects
None yet
Milestone
May 2021
Development

Successfully merging a pull request may close this issue.

Support color in terminal profiles config microsoft/vscode
4 participants
@Tyriar @meganrogge @Stirfry70 and others