-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run cells in Jupyter Notebooks #123700
Comments
(Experimental duplicate detection)
|
I have never gotten to the point where jupyter is able to execute a cell. I just hangs forever, despite having kernels detected. Maybe that's because I don't have the python extension installed? Trying this with my local toy extension that has multiple kernels but I am unable to reproduce. Is there anything async in your world, like can |
I have pushed a change that adds logging. Use F1 > Set Log Level > Trace and check the extension host output when this happens |
Also, appears the kernel as selected or suggested? The latter can be told from its tooltip. |
|
Here's everything (reload vscode and captured the logs): Detailselectron/js2c/renderer_init.js:61 The vm module of Node.js is deprecated in the renderer process and will be removed.
|
@jrieken Please could you try this #123700 (comment) |
I've been playing around with this a bit myself. I was trying to repro it in a small sample extension as I figured that might be easier to debug. I was also not able to get it to repro with a small toy application with a couple of controllers. Also tried to mimic our code that sets one of the controllers to preferred on document open. @joyceerhl Do you have the consistent repro here from this issue? microsoft/vscode-jupyter#5848. In the logging I was seeing what looked like two different python environments (python38 and pythoncodingpack) starting up, might not be the controller issue but worth investigating as well. I don't have a repro myself currently and I'd like to add some logging on our side as well. |
@IanMatthewHuff Yes I can repro this consistently. So can @claudiaregio and @DonJayamanne. I'll ping you tomorrow to discuss. |
I too can repro this consistently, and the users too are running into this. |
Not sure what logging we need, I've added the kids to my previous entry. |
I am certain it's the something to do with kernel selection and preferred, because if you manually change the kennel it works, or if you close the document and open it again (sometimes that doesn't work you must change the kernel) |
As long as I reload, I can repro consistently. Let me know if I can be of any help |
When kernels are registered, since the event is emitted but the listener is not bound yet, so the broadcasting of kernel binding is not sent to extension host. It doesn't happen with GH NB or Jupyter without Python is kernel registration happens first, and then the notebook document is created, and then the event listener is already registered. |
Thanks @rebornix |
Steps to Reproduce:
@jrieken @roblourens /cc
FYI - this is very easy to replicate and we're running into this consistently.
Our tests don't catch this as we invoke the command
executeCommand('notebook.selectKernel'
to get around an issue where VS Code prompts selection or kernels (that blocks all of our tests, hence this work around)Does this issue occur when all extensions are disabled?: N/A
The text was updated successfully, but these errors were encountered: