No tooltip shown when hovering over a terminal status

[egamma]

Testing #122241

There is no tooltip over the terminal status e.g. , the other items have a tooltip. The tooltip could say 'Relaunch Needed'.

There also is no tooltip on the bell icon.

[Tyriar]

This also happens in SCM and explorer decorations, looks like it happens because the hover listener is on .monaco-icon-label-container and not .monaco-icon-label

Changing the container to its parent will end up breaking the actions:

vscode/src/vs/base/browser/ui/iconLabel/iconLabel.ts

Line 155 in 61364b0

this.setupHover(this.labelContainer, options?.title);

[khoaleanhvn]

Anybody's working on this? If not, I will try.

[Ashray123]

Hello @jrieken, I would love to work on this issue if no one is working on it, could you provide a guide on what is to be done.

[Manish-Giri]

I would be happy to take this up. Looks like @Ashray123 has already requested to take up #124419, so this one should be available.

[timfenney]

This also happens in SCM and explorer decorations, looks like it happens because the hover listener is on .monaco-icon-label-container and not .monaco-icon-label

Changing the container to its parent will end up breaking the actions:

vscode/src/vs/base/browser/ui/iconLabel/iconLabel.ts

Line 155 in 61364b0

this.setupHover(this.labelContainer, options?.title);

Hey @Tyriar, I created the PR above, and didn't notice any broken actions on my branch. Do you mean that the other buttons won't work, e.g. for a Terminal session the 🗑️ ?

[jrieken]

@alexr00 Looping you in to this. The decorations service properly passes on the title to the icon label but it seems that the title is only applied to the text node, not the entire label. I believe doing that would break the description title (of which @bpasero seems to be the only user) so I wonder what's best here? Should the title be set up for the whole element when there is no description or no description title?

[bpasero]

I forgot why we added that for quick input, probably to avoid a hover when hovering over the label of a quick pick item but still show it when hovering over description which can be cropped.

Can we not put the hover over the entire thing if there is no description title otherwise?

[alexr00]

Should the title be set up for the whole element when there is no description or no description title?

This seems reasonable to me.

[rchiodo]

/verified