Bug in cursor location within user snippets

[richardruiter]

• VSCode Version: 1.5.0 & 1.5.1
• OS Version: OS X 10.11.6 (15G1004)

Steps to Reproduce:

1. Add the following snippet to the javascript.json user snippets file:

{
     "Print to console": {
        "prefix": "log",
        "body": [
            "console.log('$1');"
        ],
        "description": "Log output to console"
    }
}

1. Then open an .js file and type "log" ENTER to insert the snippet.

Before the update of 1.5.0 the cursor appeared at $1 console.log('|'); now at the end of the line console.log('');|

[ramya-rao-a]

@richardruiter I tried in OS X El Capitan 10.11.6 and Windows 10 with VS Code 1.5.1 and can't repro this. The cursor ends up in the right place.

Are you able to see this when extensions are disabled? Try running code --disable-extensions

@jrieken Assigning to you since you were the last person touching the snippets side of things as far as I know

[jrieken]

same here - failing to reproduce. @richardruiter Please update your steps/sample

[ITSecMedia]

This very annoying bug happens on my machine too.
Recognised in markdown snippets.
Windows 10 x64 since Version 1.5.0 up to 1.5.1.

[jrieken]

@ITSecMedia It would help if you include reproducible steps and the snippet you are completing

[jrieken]

Just to make sure are talking about the same thing. This is what I see and believe is proper.

Markdown bold snippet

Custom snippet as shown above

[ITSecMedia]

Sorry, I expected the bug is obvious.

Just opened VSCode, started new markdown file using this snippet.

The defined tab-stops in the snippets doesn't work anymore. When I have a text like this.

example [example](sc <-shortcode) example example example CURSOR HERE

The cursor is not placed at position $1 inside the placed snippet but rather at the end of line.

{
     "ShortCode": {
        "prefix": "sc",
        "body": [
            "{{% url_**$1** %}}"
        ],
        "description": "Insert ShortCode"
    }
}

[jrieken]

Thanks. I can reproduce now

[jrieken]

As a workaround you can use tab completion (settings > "editor.tabCompletion": true) which isn't affected by this.

[ITSecMedia]

On my machine the bug occurs no matter if
I press Enter after choosing the snippet
or if I use the tab-completion feature with enabled setting ( "editor.tabCompletion": true )
The cursor is always send far behind the defined $1 tab-stop-cursor-position inside the placed snippet.
But I can wait, until it's fixed.
Thank you, we all LOVE VSCode :-)

[rengare]

Hello, i have the same issue, but on every snippets that I downloaded (angular 1, 2 html and my custom snippets).
Greetings

[jrieken]

or if I use the tab-completion feature with enabled setting ( "editor.tabCompletion": true )
The cursor is always send far behind the defined $1 tab-stop-cursor-position inside the placed snippet.

That's likely because the completion window eats the tab (instead of the tab controller). Try to also hide snippets from the suggest window (only tab completion)

[jrieken]

My above workaround isn't valid - this only works when you are at column: 1 or with multiline snippets. I have pushed a fix now

[jrieken]

To verify

• have a snippet like above
• type foo foo sc and complete the snippet
• make sure the cursor is between the **-parts

[mrmlnc]

@jrieken, hmm, broken cases (with your fix):

{
    "after": {
        "prefix": "aftr",
        "body": [
            "afterEach((done) => {",
            "\t${1}test",
            "});"
        ],
        "description": "Mocha BDD: after() | afterEach()"
    }
}

{
    "after": {
        "prefix": "aftr",
        "body": [
            "afterEach((done) => {",
            "${1}\ttest",
            "});"
        ],
        "description": "Mocha BDD: after() | afterEach()"
    }
}

[jrieken]

@mrmlnc This is with version what?

[mrmlnc]

@jrieken, with latest commit (9606db1) in a release-1.5 branch.

[jrieken]

I'll take a look

[jrieken]

While fixing this I encountered a bigger underlying problem which is a more complex... Needs more thinking or we revert the change (simple snippets for multiple cursors) for 1.5 and revisit for Sept

[cauldyclark15]

Hello, I am still having the issue same with #11782, cursor is not between quotes after autocomplete on HTML. I just updated to VS Code version 1.5.1, and using Windows 7. I am new here so if you need additional information from me, please advice.

[jrieken]

@cauldyclark15 You need to wait for 1.5.2 or built from source

[cauldyclark15]

@jrieken Thank you for your response, I understand now.

[dburles]

Since this fix for some reason snippets only work once

[dburles]

Still seeing the above issue

[ramya-rao-a]

@dburles I am able to confirm that the issue described above in #11742 (comment) and #11742 (comment) are working as expected.

Are you referring to these linked issues or your earlier comment of "snippets only work once" ?

[dburles]

Sorry yeah the issue with snippets only working once. It's a strange one and I just haven't had time to dig into it. Basically I'll be able to write 'log[tab]' and have it expand to console.log(...) just fine but only one time, until I restart vscode.

[ramya-rao-a]

@dburles Can you create a new issue for that since this issue is more about the cursor position after snippet expansion?

[dburles]

Sure. Though I do recall that it wasn't a problem until this fix was released so it's possibly related.

[ramya-rao-a]

@dburles In that case, do add a note about it in the new issue. Thanks!

[unChartedZone]

This used to be an issue on osx, primarily with HTML files, this occurred right after a certain release of vscode, I think 1.7.0, but an update to 1.7.1 fixed it, I'm guessing Windows didn't get the same fix

[alanldawkins]

I have the same problem too, snippets only work for $1 and the it skip all next to the end of the snippet, if you've set $0, it will be $1 -> $0, all others will be skipped too. Both on Windows( my version is enterprise 10) and Ubuntu ( 16.04.2).
Since this issue I've give up snippets for a long time. : (