Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions list doesn't auto-update when sync is installing extensions #100415

Closed
miguelsolorio opened this issue Jun 17, 2020 · 4 comments
Closed
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync ux User experience issues verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

This came up a lot in our previous user studies and thought we filed this issue.

  1. Open extensions list before turning on sync
  2. Turn on sync
  3. 🐛 Extensions list never gets updated

image

But when I update the query it shows the right info:

image

We should auto-refresh the list once sync starts installing extensions so users can see the update in real-time

@sandy081
Copy link
Member

sandy081 commented Jun 19, 2020

It seems user did not have any extensions before and when user opens extensions, Marketplace extensions are shown by default.

I agree that in this case the default view shall be updated to installed extensions. It means view does not get updated if user switches to Marketplace extensions intentionally lets say by typing in search input.

@sandy081 sandy081 added extensions Issues concerning extensions polish Cleanup and polish issue labels Jun 19, 2020
@sandy081 sandy081 added this to the June 2020 milestone Jun 19, 2020
@sandy081
Copy link
Member

sandy081 commented Jul 1, 2020

@misolori I thought about this a bit and it might not be really clear when to auto refresh or not, because user might be browsing Marketplace extensions in the view at this point and auto refreshing might not be intended?

Is there any other passive approach like a hint or something in extensions view to represent extensions are installed/auto updated in the background?

@sandy081 sandy081 added ux User experience issues and removed polish Cleanup and polish issue labels Jul 1, 2020
@sandy081 sandy081 modified the milestones: June 2020, Backlog Jul 1, 2020
@miguelsolorio
Copy link
Contributor Author

I think that if the user has the default view (no query) or any of the installed queries (installed, enabled, etc.) we should update the list. If they are searching through the marketplace then that makes sense to not update the list. However, in my experience when sync is installing extensions and I've searched through the marketplace the default view never gets updated long after extensions are installed (like when you clear your results). So we should make sure that is accounted for as well.

This is one of the things that came up a lot in the user study and most people were confused/thought it didn't work.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Nov 3, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 18, 2020

Installed Extensions view is always shown now

image

When extensions are installed either manually or through setting sync, installed list gets auto updated

image

Popular list is not removed immediately but removed after refresh.

sandy081 added a commit that referenced this issue Nov 18, 2020
meganrogge pushed a commit that referenced this issue Nov 18, 2020
meganrogge pushed a commit that referenced this issue Nov 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rzhao271 @sandy081 @miguelsolorio and others