Skip to content

Commit

Permalink
Opt debug console filter box into nice overflow behavior (#169342)
Browse files Browse the repository at this point in the history
Also fix an issue with the body height calculation when the filter box is in the body
Fix #140540
  • Loading branch information
roblourens authored Dec 16, 2022
1 parent 1d7b98a commit c67a8af
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/vs/base/browser/ui/selectBox/selectBox.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

.monaco-action-bar .action-item .monaco-select-box {
cursor: pointer;
min-width: 110px;
min-width: 70px;
min-height: 18px;
padding: 2px 23px 2px 8px;
}
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/browser/parts/views/media/views.css
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@

.panel > .title .monaco-action-bar .action-item.viewpane-filter-container {
max-width: 400px;
min-width: 300px;
min-width: 150px;
margin-right: 10px;
}

Expand Down
4 changes: 3 additions & 1 deletion src/vs/workbench/browser/parts/views/viewPane.ts
Original file line number Diff line number Diff line change
Expand Up @@ -689,9 +689,11 @@ export abstract class FilterViewPane extends ViewPane {
this.updateActions();
if (!shouldShowFilterInHeader) {
append(this.filterContainer!, this.filterWidget.element);
height = height - 44;
}
}
if (!shouldShowFilterInHeader) {
height = height - 44;
}
this.filterWidget.layout(width);
this.layoutBodyContent(height, width);
}
Expand Down
4 changes: 0 additions & 4 deletions src/vs/workbench/contrib/debug/browser/repl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,6 @@ export class Repl extends FilterViewPane implements IHistoryNavigationWidget {
this.replInput.layout({ width: width - 30, height: replInputHeight });
}

override shouldShowFilterInHeader(): boolean {
return true;
}

collapseAll(): void {
this.tree.collapseAll();
}
Expand Down

0 comments on commit c67a8af

Please sign in to comment.