Skip to content

Commit

Permalink
Icons missing from extension trees with resource uris (#152039)
Browse files Browse the repository at this point in the history
Fixes #152036
  • Loading branch information
alexr00 authored Jun 14, 2022
1 parent ab220b2 commit 30d9c6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vs/workbench/browser/parts/views/treeView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
private shouldHideResourceLabelIcon(iconUrl: URI | undefined, icon: ThemeIcon | undefined): boolean {
// We always hide the resource label in favor of the iconUrl when it's provided.
// When `ThemeIcon` is provided, we hide the resource label icon in favor of it only if it's a not a file icon.
return !!iconUrl || !this.isFileKindThemeIcon(icon);
return (!!iconUrl || (!!icon && !this.isFileKindThemeIcon(icon)));
}

private shouldShowThemeIcon(hasResource: boolean, icon: ThemeIcon | undefined): icon is ThemeIcon {
Expand Down

1 comment on commit 30d9c6c

@mkexchange
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD ISSUE DESCRIPTION HERE

Version: 1.68.1
Commit: 30d9c6c
User Agent: Mozilla/5.0 (Linux; Android 11; SM-A025F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.0.0 Mobile Safari/537.36
Embedder: github.dev

Please sign in to comment.