fix #930 and hopefully pass azure pipeline tests #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
requested changes
May 29, 2024
|
Yes. I assumed it was why my original pull request was closed. https://github.com/microsoft/vscode-vsce/pull/937/checks
I don't see those checks on this pull request. |
|
@RobbyCBennett What node version are you using? We support node up to LTS version |
|
I had version 22, which was installed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already tried fixing this runtime issue with #937, but that failed some Azure pipeline tests. I don't know why it failed because I can't see the output of the tests. Maybe this will work if I change both package.json and package-lock.json.