Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Yarn Berry & pnpm support #876

Conversation

ivangabriele
Copy link

@ivangabriele ivangabriele commented Jul 4, 2023

This is a work in progress, far from finished.

Don't be frightened by the diff: the first commit in this PR is a proposal to add Prettier w/ EditorConfig using a config as close as possible to the original coding style. Most of the diff is the result of code linting.

Related Issues

@ivangabriele
Copy link
Author

@microsoft-github-policy-service agree

@joaomoreno
Copy link
Member

joaomoreno commented Jul 4, 2023

proposal to add Prettier w/ EditorConfig

Please remove this, since we don't use prettier in the team nor plan to introduce it. Thanks!

Excited for the changes!

@mrmckeb
Copy link

mrmckeb commented Aug 1, 2023

Can I help with this PR in any way @ivangabriele? Also very excited to see this land!

@ivangabriele
Copy link
Author

@mrmckeb Sorry I'm on vacation until the end of this week and I try to "cut" during this period. I'll update my work-in-progress next week and ping you if I need help by then, thank you very much!

@joaomoreno
Copy link
Member

Closing this as out of scope. As part of our recurring maintenance milestone, we've decided to limit the amount of supported package managers to npm and yarn v1 only.

@joaomoreno joaomoreno closed this Dec 13, 2023
@mrmckeb
Copy link

mrmckeb commented Dec 15, 2023

Hi @joaomoreno, would you be open to PRs here?

I definitely understand the burden of supporting multiple package managers, but wanted to note:

  • For organizations like ours, where we're building our extension inside of a large monorepo, we can't simply change package manager.
  • pnpm is now 2x the installs of Yarn (via the npm registry), and continues to grow in popularity.

@aleclarson
Copy link

Bumping this in hopes that the team reconsiders PNPM support.

At the time of writing, PNPM has 28.9k stars versus Yarn's 41.4k. I think it's safe to say that the people have spoken, and PNPM is here to stay.

In addition, if you look at this PR's changes (ignoring the formatting-related ones), they are straight-forward and don't add much in terms of maintenance cost, since the package manager APIs used are extremely stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yarn v2 Support pnpm
4 participants