Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for publisher in vsce package #487

Closed
wants to merge 1 commit into from

Conversation

vojtechkral
Copy link

Fix #328

This is quite an annoying bug when one wants to publish a private / organization-internal extension to co-workers...

I fixed it in a really simple way, not sure it this is good enough...

@vojtechkral
Copy link
Author

I fixed it in a really simple way, not sure it this is good enough...

In fact, it's not. Just removing the function causes VS Code to error out with Cannot read property 'toLocaleLowerCase' of undefined.

Not sure what to do about that...

@Supitto
Copy link

Supitto commented Jan 13, 2021

@vojtechkral I am building an independent packager and stumbled upon this. Apparently the function installFromVSIX https://github.com/microsoft/vscode/blob/a416c1534bb9159c7ad9d88f19d70019ded16a6a/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts#L1032) uses a field 'publisher' from the extension. If you add the field 'publisher' into the package.json like this

{ "publisher": "test", "name": "something",

vscode will recognize this as the publisher and properly register the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsce package should not check for publisher
2 participants