Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for yarn workspaces #458

Closed
wants to merge 0 commits into from

Conversation

sebas2day
Copy link
Contributor

Fixes #300

This PR is inspired by #379.

I have included a small yarn workspaces fixture in order to test whether its collecting the files in the right way.

@joaomoreno joaomoreno self-assigned this Jun 24, 2020
@joaomoreno joaomoreno self-requested a review June 24, 2020 11:02
@phaumer
Copy link

phaumer commented Aug 7, 2020

@sebas2day I am trying this PR for a yarn workspace that has a VS Code extension that uses webpack. However, some packages need to be added from the node_modules as they are read at runtime. So I added this in the .vscodeignore file

node_modules/**
../../node_modules/**
!../../node_modules/vscode-jsonrpc/**
!../../node_modules/vscode-languageclient/**
!../../node_modules/vscode-languageserver-protocol/**
!../../node_modules/vscode-languageserver-types/**
!../../node_modules/vscode-nls/**

None of these were included. Should that work?

@sebas2day
Copy link
Contributor Author

@phaumer Hmm yes the .vscodeignore file might not fully work as expected. I think it would be good to first merge this PR #418 to make the implementation of .vscodeignore simpler so we can eventually fix it later in this PR

@sebas2day
Copy link
Contributor Author

@joaomoreno Any updates on this?

@sebas2day
Copy link
Contributor Author

Sorry in order to resolve the conflicts with master I had to create another PR (and made it a separate branch this time)
See #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yarn workspaces
3 participants