Suggest bundling when having many files #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before publishing this version we must publish the website update |
|
Are there any other signs we could check besides file count > 100? @chrisdias also suggests we should check whether webpack is in the dependencies: #334 |
|
Having webpack doesn't mean you know how to use it ;-) Tho, we should check now many JS-files you have. |
|
Right, what if it's already bundled, does the user have to read this message all the time she packages? |
|
If you bundle in 100+ files then you are doing it wrong |
|
Just ping me when this should be published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This for #333 and suggests to bundle when having an extension with more than 100 files. The limit 100 is a bit arbitrary tbh, open for other suggestions. 50? 1000?