Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punycode deprecation warning #1037

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

mark-wiemer
Copy link
Contributor

Fix #930

markdown-it<14 depended on punycode, which has now been deprecated in Node 22. Updating this dependency resolves the warning.

@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 26, 2024
@benibenj benibenj merged commit e646982 into microsoft:main Aug 26, 2024
8 checks passed
@mark-wiemer mark-wiemer deleted the users/markwiemer/930-punycode branch August 27, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
4 participants