Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated dependencies #1027

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Update deprecated dependencies #1027

merged 1 commit into from
Jul 19, 2024

Conversation

benibenj
Copy link
Contributor

This pull request updates the deprecated dependencies in the project. The glob dependency has been updated from version 7.0.6 to 11.0.0, and the tmp dependency has been updated from version 0.2.1 to 0.2.3. Additionally, the @types/glob dependency has been updated from version 7.1.1 to 8.1.0. These updates ensure that the project is using the latest versions of the dependencies and avoids any potential issues caused by deprecated functionality.

closes #959
closes #1026

@benibenj benibenj enabled auto-merge July 19, 2024 08:14
@benibenj benibenj merged commit ca8fa40 into main Jul 19, 2024
11 checks passed
@benibenj benibenj deleted the benibenj/logical-duck branch July 19, 2024 08:47
@xoriath
Copy link

xoriath commented Jul 19, 2024

hrm, the new glob requires node 20 | >= 22... so just rolling the minor version for this breaks a lot of things :)

so https://github.com/microsoft/vscode-vsce/blob/main/package.json#L38 is no longer correct, there is no chance to run on 16, and any dependents on this (like ovsx) is also broken when running on node < 20... which will most likely happen since this was only rolled into a .1 'bugfix' ...

Could we roll this back, release a .2 to unbreak people, and then pull this back into a 3.x version with the correct engine requirement?

@mattkubej
Copy link

Similarly got bit by the glob upgrade. We're packaging a TypeScript server plugin with a VSCode Extension, which was installed via a symlink. From looking at their changelog, I think we likely encountered "exclude symbolic links to directories when follow and nodir are both set". So, package was not including our dependency.

I was able to workaround this by not installing with a symlink, but just wanted to share in case others hit this.

@benibenj
Copy link
Contributor Author

@xoriath thanks for mentioning this. You are right, we should actually create a major release for this. I'll create a new minor with the old glob version and publish a major with the node 20 requirement.

@xoriath
Copy link

xoriath commented Aug 15, 2024

@xoriath thanks for mentioning this. You are right, we should actually create a major release for this. I'll create a new minor with the old glob version and publish a major with the node 20 requirement.

Perfect, thanks a bunch! :) Now I have to fix our stuff so we can follow onto the 3.x release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glob 7.* is going EOL
4 participants