-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extensions pulling README content from an alternate file #905
Comments
I'd like this for the |
README.md is outside the extension directory. Updated @vscode/vsce to get --readme-path flag support. (Still in a prerelease state. See microsoft/vscode-vsce#905). Change-Id: Ie9ed25643307ae8827bbf15589be131019a9159b Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/556535 Commit-Queue: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Suzy Mueller <[email protected]> TryBot-Result: kokoro <[email protected]>
Thanks @joaomoreno. We recently reorganized our repo structure and README.md file is in the parent directory of package.json.
|
It needs to be inside the extension folder. Just add a |
@joaomoreno am I doing something wrong? My extension structure:
I run:
that runs ok but when I crack open the VSIX:
I'm not sure where I should expect a change, but I can't seem to find one if it has been done. |
This only affects the files for displaying in the Marketplace. This means:
|
Also, I hadn't published vsce with the changes. :D That explains it. 😆 🚀 Just published @vscode/[email protected]. To verify, confirm the
|
If I understand this correctly:
If you install a local extension using Install from VSIX...* then we should not expect the README to be displayed. Right? 🤦 |
I've run into a similar issue to as #210 and #722, where I'm using a single README file for 2 different purposes:
For example, it's weird to read build instructions in the marketplace, but useful to mention for developers on GitHub.
I understand that this must be limited in scope to avoid sweeping changes being necessary, so I propose the following:
A new option named "readmePath" is added to command line, and/or the package.json manifest.
When set, it copies the specified file into the package and renames it to "README", overriding any file already having that name.
This way no updates would be required to the marketplace, it still pulls from README just like it always has.
But it gives extension developers to flexibility to pull what gets displayed in the marketplace from another file.
I'm totally fine opening a PR to add this functionality! I just wanted to gauge if this proposal was okay before I potentially wasted any time implementing it.
The text was updated successfully, but these errors were encountered: