-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when downloading VS Code #233
Comments
I'm seeing the same thing:
But on the rename of the temp down. My tests will not run as a result of this, and VS Code is operating as an Admin. Please help. |
I was able to hit that locally it one case, it seems that adding a retry to the rename was sufficient to fix it. Please give @vscode/test-electron 2.3.5 a try and let me know if you still hit it. |
@connor4312 still happening for me on 2.3.5
Weirdly, when I go to manually delete the tmp folder, I get an admin popup not sure what kind of permissions weirdness may be happening here, they look normal to me in the properties and are set to inherit. EDIT: The popup appears to be because vscode still has a handle open in that folder. Killing the process and it works. Maybe related? EDIT2: If I start the test outside vscode, e.g. from windows terminal, it works fine, so something in vscode holding a handle in that folder it shouldn't be? |
That's unfortunate. That seems to be a bug on VS Code itself, it should not lock folders like that. I think that is distinct from OP's issue, since their happens in CI |
I cannot reproduce, here is what I tried:
Anything else? Does it reproduce in VS Code insiders? |
Looks like the failure is still present in OP's CI 😢 |
Sorry for the late response. This still repros for us after updating to 2.3.5. |
Fixes #233, which Andrea ran into when testing. Instead of staging and renaming, which tends to fail on Windows, write a 'completed' file when the install is done.
We have a pipeline running some extension tests. After 1.82.1 release, we see consistent permission error after downloading VS Code (removed some download progress output):
vscode/test-electron version is 2.3.4. We checked the permissions of code.exe file in the tmp folder, and everything seems to be correct.
The text was updated successfully, but these errors were encountered: