Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to run test in [email protected] but work on 1.78.2 #221

Closed
zWingz opened this issue Jun 9, 2023 · 5 comments
Closed

Failed to run test in [email protected] but work on 1.78.2 #221

zWingz opened this issue Jun 9, 2023 · 5 comments
Assignees

Comments

@zWingz
Copy link

zWingz commented Jun 9, 2023

  • VS Code Version: 1.79.0
  • OS Version: centos6

Steps to Reproduce:

  1. create a vscode extension
  2. run test

Failed in 1.79.0

yarn run v1.22.19
$ node ./out/test/runTest.js
Downloading VS Code 1.79.0 from https://update.code.visualstudio.com/1.79.0/linux-x64/stable
Downloading VS Code [============================--] 96%Downloaded VS Code 1.79.0 into /workspace/p-f11da099be374c5b909e1abd486d08f0/src/.vscode-test/vscode-linux-x64-1.79.0
Downloading VS Code [==============================] 100%[1116:0609/181436.242608:ERROR:bus.cc(399)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[1116:0609/181436.242716:ERROR:bus.cc(399)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[1161:0609/181436.306734:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
WARNING: IPC handle "/workspace/p-f11da099be374c5b909e1abd486d08f0/src/.vscode-test/user-data/1.79-main.sock" is longer than 107 chars, try a shorter --user-data-dir
[0609/181436.361256:FATAL:electron_main_delegate.cc(304)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
[1116:0609/181436.373705:ERROR:network_service_instance_impl.cc(521)] Network service crashed, restarting service.
[1201:0609/181436.380107:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[0609/181436.389405:FATAL:electron_main_delegate.cc(304)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
[main 2023-06-09T10:14:36.430Z] update#ctor - updates are disabled by the environment
[1116:0609/181436.432416:ERROR:bus.cc(399)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[1116:0609/181436.437697:ERROR:network_service_instance_impl.cc(521)] Network service crashed, restarting service.
[0609/181436.454048:FATAL:electron_main_delegate.cc(304)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
[1116:0609/181436.456852:ERROR:network_service_instance_impl.cc(521)] Network service crashed, restarting service.
[0609/181436.472173:FATAL:electron_main_delegate.cc(304)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
[1116:0609/181436.474859:ERROR:network_service_instance_impl.cc(521)] Network service crashed, restarting service.

but work on 1.78.2
image

image
philipp-spiess added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this issue Jun 9, 2023
As of the latest VS Code update, we see our extension test not working
properly across both the integration and E2E setups. This seems to be an
upstream problem and was also reported here:
microsoft/vscode-test#221

This PR hardcodes these setups to use the previous version.
 
## Test plan

- CI passes again

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
@connor4312
Copy link
Member

VS Code 1.79 enables sandboxing by default, which looks like it causes this issue. As suggested by the error log, you should be able to work around it by adding launchArgs: ["--no-sandbox"], in your call to `runTests.

@bpasero do you think it'd be reasonable to add --no-sandbox as a default when running in @vscode/test-electron, or should we just perhaps scan the logs and add a more helpful output for extension authors to update their test code?

@shenglol
Copy link
Member

shenglol commented Jun 9, 2023

We are also getting the error since yesterday. I tried adding --no-sandbox and --disable-gpu-sandbox to launchArgs, but it didn't help. Also, it seems the error only happens in our Azure DevOps pipeline which uses containerized build agents, but not in our GitHub Actions workflow which uses GitHub-hosted VMs.

@connor4312
Copy link
Member

Let's merge into microsoft/vscode#184687

@connor4312 connor4312 added the duplicate This issue or pull request already exists label Jun 9, 2023
@connor4312 connor4312 reopened this Jun 10, 2023
@connor4312 connor4312 removed the duplicate This issue or pull request already exists label Jun 10, 2023
@bpasero bpasero assigned deepak1556 and unassigned bpasero Jun 13, 2023
@bpasero
Copy link
Member

bpasero commented Jun 13, 2023

I would suggest that we set the same CLI args that we also set for our test runs in our CI.

@connor4312
Copy link
Member

Fixed this in #222 and published

ErikaRS pushed a commit to sourcegraph/sourcegraph-public-snapshot that referenced this issue Jun 22, 2023
As of the latest VS Code update, we see our extension test not working
properly across both the integration and E2E setups. This seems to be an
upstream problem and was also reported here:
microsoft/vscode-test#221

This PR hardcodes these setups to use the previous version.
 
## Test plan

- CI passes again

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants