-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to run test in [email protected] but work on 1.78.2 #221
Comments
As of the latest VS Code update, we see our extension test not working properly across both the integration and E2E setups. This seems to be an upstream problem and was also reported here: microsoft/vscode-test#221 This PR hardcodes these setups to use the previous version. ## Test plan - CI passes again <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
VS Code 1.79 enables sandboxing by default, which looks like it causes this issue. As suggested by the error log, you should be able to work around it by adding @bpasero do you think it'd be reasonable to add --no-sandbox as a default when running in @vscode/test-electron, or should we just perhaps scan the logs and add a more helpful output for extension authors to update their test code? |
Found the solution here: microsoft/vscode-test#221 (comment) ###### Microsoft Reviewers: [Open in CodeFlow](https://portal.fabricbot.ms/api/codeflow?pullrequest=https://github.com/Azure/bicep/pull/10937)
We are also getting the error since yesterday. I tried adding |
Let's merge into microsoft/vscode#184687 |
I would suggest that we set the same CLI args that we also set for our test runs in our CI. |
Fixed this in #222 and published |
As of the latest VS Code update, we see our extension test not working properly across both the integration and E2E setups. This seems to be an upstream problem and was also reported here: microsoft/vscode-test#221 This PR hardcodes these setups to use the previous version. ## Test plan - CI passes again <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Steps to Reproduce:
Failed in 1.79.0
but work on 1.78.2
The text was updated successfully, but these errors were encountered: