Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engineering - React to template changes #53

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Engineering - React to template changes #53

merged 3 commits into from
Nov 3, 2022

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Nov 3, 2022

No description provided.

@lszomoru lszomoru enabled auto-merge (squash) November 3, 2022 12:40
@lszomoru lszomoru self-assigned this Nov 3, 2022
@lszomoru lszomoru requested a review from aeschli November 3, 2022 12:41
@aeschli
Copy link
Contributor

aeschli commented Nov 3, 2022 •
edited
Loading

@lszomoru I updated the pipeline and package.json to rely on prepack
What's nice about prepack is that it would also be called if a user manually runs npm pack and also for npm release, So IMO it's the right thing to do.

@aeschli aeschli added this to the October 2022 milestone Nov 3, 2022
@lszomoru lszomoru merged commit 8ef2fd8 into main Nov 3, 2022
@lszomoru lszomoru deleted the lszomoru/provincial-clownfish branch November 3, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschli aeschli aeschli approved these changes

Assignees

@lszomoru lszomoru

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@lszomoru @aeschli