Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxExtensionMain encodes its filenames, but shouldn't #50

Closed
sandersn opened this issue Oct 18, 2022 · 0 comments · Fixed by #51
Closed

fxExtensionMain encodes its filenames, but shouldn't #50

sandersn opened this issue Oct 18, 2022 · 0 comments · Fixed by #51
Assignees
Milestone

Comments

@sandersn
Copy link
Member

I'm running code-web locally like so: ./scripts/code-web.sh /home/sandersn/src/test --coi

I have a tsserver that uses @vscode/sync-api-client for its filesystem; @vscode/sync-api-service then uses vscode-test-web for commands like stat, which calls into fsExtensionMain.getStats when code-web is passed a local folder.

The problem is that when passed a Uri with path: "node_modules/@types/node, it calls toString() on that uri, which produces "node_modules/%40types/node". This path is not found on the filesystem. When toString(/*skipEncoding*/ true) is used instead the path is not escaped, and is correctly found on the filesystem.

This might be a limitation of the filesystem provided by @vscode/sync-api-service, but I don't think so. Tagging @jrieken in case he can contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants