Skip to content

Commit

Permalink
Engineering - add npm pipeline (#44)
Browse files Browse the repository at this point in the history
* Scaffold pipeline

* Ignore build folder

* Add test steps

* Try running browser headless

* Do not run headless

* Add build platforms

* Try running headless

* Fixing some issues for Windows

* Only run on Windows

* Remove headless flag

* Upgrade Playwright

* Add back the platforms

* Bring back the --headless flag

* Try a conditional task

* Revert the flag

* Switch to a predefined variable

* Trying various things

* Add back a platform

* Another attempt
  • Loading branch information
lszomoru authored Oct 6, 2022
1 parent 4685a56 commit 45b8d7c
Show file tree
Hide file tree
Showing 4 changed files with 78 additions and 10 deletions.
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
.eslintrc.js
.prettierrc
.github/
build/
src/
sample/
fs-provider/src/
Expand Down
67 changes: 67 additions & 0 deletions build/pipeline.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
name: $(Date:yyyyMMdd)$(Rev:.r)

trigger:
branches:
include:
- main
tags:
include: ['*']
pr: none

resources:
repositories:
- repository: templates
type: github
name: microsoft/vscode-engineering
ref: main
endpoint: Monaco

parameters:
- name: publishPackage
displayName: 🚀 Publish Package
type: boolean
default: false

extends:
template: azure-pipelines/npm-package/pipeline.yml@templates
parameters:
buildPlatforms:
- name: Linux
nodeVersions:
- 14.x
- 16.x
- name: MacOS
nodeVersions:
- 14.x
- 16.x
- name: Windows
nodeVersions:
- 14.x
- 16.x

buildSteps:
- script: yarn --froze-lockfile
displayName: Install dependencies

- script: yarn --cwd=fs-provider --froze-lockfile
displayName: Install dependencies (fs-provider)

- script: yarn compile
displayName: Compile npm package

testSteps:
- bash: |
/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
echo ">>> Started xvfb"
displayName: Start xvfb
condition: eq(variables['Agent.OS'], 'Linux')
- script: yarn --cwd=sample --froze-lockfile
displayName: Install dependencies (sample)

- script: yarn sample-tests
displayName: Test npm package
env:
DISPLAY: ':99.0'

publishPackage: ${{ parameters.publishPackage }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"koa-mount": "^4.0.0",
"koa-static": "^5.0.0",
"minimist": "^1.2.6",
"playwright": "^1.23.1",
"playwright": "^1.26.1",
"vscode-uri": "^3.0.3",
"http-proxy-agent": "^5.0.0",
"https-proxy-agent": "^5.0.1",
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1478,17 +1478,17 @@ pinkie@^2.0.0:
resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870"
integrity sha1-clVrgM+g1IqXToDnckjoDtT3+HA=

playwright-core@1.23.1:
version "1.23.1"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.23.1.tgz#af02bd7568af1017e477433b1b003ba84e1eb312"
integrity sha512-9CXsE0gawph4KXl6oUaa0ehHRySZjHvly4TybcBXDvzK3N3o6L/eZ8Q6iVWUiMn0LLS5bRFxo1qEtOETlYJxjw==
playwright-core@1.26.1:
version "1.26.1"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.26.1.tgz#a162f476488312dcf12638d97685144de6ada512"
integrity sha512-hzFchhhxnEiPc4qVPs9q2ZR+5eKNifY2hQDHtg1HnTTUuphYCBP8ZRb2si+B1TR7BHirgXaPi48LIye5SgrLAA==

playwright@^1.23.1:
version "1.23.1"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.23.1.tgz#b029885e995aa1f9626aac851410c5ef615718f4"
integrity sha512-+lgiy1JZMNPwpBp5tsUdjTGxuJ+lXZbtSKmMDc0/f1oVsNDXXA+r7zeC9Kzd+4jSHteoJJocargxVx2Mn1o2kw==
playwright@^1.26.1:
version "1.26.1"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.26.1.tgz#0082c1d6a1c9cefe3f7a593396ad8568746184d0"
integrity sha512-WQmEdCgYYe8jOEkhkW9QLcK0PB+w1RZztBLYIT10MEEsENYg251cU0IzebDINreQsUt+HCwwRhtdz4weH9ICcQ==
dependencies:
playwright-core "1.23.1"
playwright-core "1.26.1"

prelude-ls@^1.2.1:
version "1.2.1"
Expand Down

0 comments on commit 45b8d7c

Please sign in to comment.