Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render spring icons as gutters #291

Merged
merged 1 commit into from
Mar 16, 2023
Merged

render spring icons as gutters #291

merged 1 commit into from
Mar 16, 2023

Conversation

Eskibear
Copy link
Member

This PR uses ThemableDecorationRenderOptions.gutterIconPath to render spring gutter icons, while previously it's mimic by adding icons/placeholders using :before styling for each line.

@Eskibear
Copy link
Member Author

Pros:

Cons:

@Eskibear
Copy link
Member Author

Demo:

spring-gutter-native.mp4

@nickzhums
Copy link
Member

Nice, qq, at 0:04, when you clicked the icon, what happened?

@Eskibear
Copy link
Member Author

Nice, qq, at 0:04, when you clicked the icon, what happened?

Nothing happens now. But with vscode's proposed API, we can put some commands there. The UI is Like something as below:
image

@nickzhums
Copy link
Member

nickzhums commented Mar 14, 2023

Nice, qq, at 0:04, when you clicked the icon, what happened?

Nothing happens now. But with vscode's proposed API, we can put some commands there. The UI is Like something as below: image

Nice, that would be useful in the future. Looks damn good to me

@Eskibear Eskibear merged commit 63f9ace into main Mar 16, 2023
@Eskibear Eskibear deleted the gutter branch March 16, 2023 05:26
@Eskibear
Copy link
Member Author

Follow-up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants