Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature name instead of id is recorded in the image metadata #7253

Closed
alexdima opened this issue Sep 27, 2022 · 0 comments
Closed

Feature name instead of id is recorded in the image metadata #7253

alexdima opened this issue Sep 27, 2022 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded

Comments

@alexdima
Copy link
Member

Testing #7248

[
    {
        "id": "terraform",
        "customizations": {
            "vscode": {
                "extensions": [
                    "HashiCorp.terraform",
                    "ms-azuretools.vscode-azureterraform"
                ],
                "settings": {
                    "terraform.languageServer.enable": true,
                    "terraform.languageServer.args": [
                        "serve"
                    ],
                    "azureTerraform.terminal": "integrated"
                }
            }
        }
    },
    {
        "postAttachCommand": "echo 'Hello from the postAttachCommand in the base image!'",
        "customizations": {
            "vscode": {
                "extensions": [
                    "chrmarti.regex"
                ]
            }
        }
    }
]

I would have expected the id of the first element in the JSON array to be ghcr.io/devcontainers/features/terraform or ghcr.io/devcontainers/features/terraform:1.0.5 instead of terraform.

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers labels Sep 28, 2022
@chrmarti chrmarti added this to the September 2022 milestone Sep 28, 2022
chrmarti added a commit to devcontainers/cli that referenced this issue Sep 29, 2022
chrmarti added a commit to devcontainers/cli that referenced this issue Sep 29, 2022
chrmarti added a commit to devcontainers/cli that referenced this issue Sep 29, 2022
@chrmarti chrmarti modified the milestones: September 2022, October 2022 Sep 30, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants