New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local React Native Cli support #1093

Merged

RedMickey merged 56 commits into microsoft:master from RedMickey:local-react-native-cli

Oct 25, 2019

Contributor

RedMickey commented Sep 3, 2019 •

edited

Loading

Added React Native local CLI support for the extension.
Changed function of getting React Native version.
Added unit tests for a new getting React Native version function.
Added a new error ReactNativePackageIsNotInstalled with code 606. This error will be thrown if there isn't react-native package in project's node modules.
Resolves #1101

The following table represents telemetry events changes:

New React Native local CLI approach	Old React Native global CLI approach
Added a new step `getReactNativeVersion` to `launch` sequence. This step and other steps in `launch` sequence can contain an error number `606`:	`getReactNativeVersion` step doesn't exist. The rest of the steps don't contain error number `606` field.
The following telemetry events can contain error number `606`: commandPalette.runAndroidSimulator commandPalette.runAndroidDevice commandPalette.startPackager commandPalette.restartPackager commandPalette.runIosDevice commandPalette.runIosSimulator commandPalette.runExponent RNCommand commandPalette.publishToExpHost For example `commandPalette.startPackager` event could be as following:	These events don't contain error number `606` field.

RedMickey added 5 commits

September 2, 2019 13:34


          add new getReactNativeVersion method

48ee1f8


          add local RN cli support for debugging

381f59b


          set local cli as default parameter

e0fe4db


          Thow logger from rn-extension to commandExec

a0ead38


          add a description for useGlobalReactNativeCLI parameter

022ada4

SounD120 self-requested a review

September 3, 2019 08:20

RedMickey and others added 3 commits

September 3, 2019 12:35


          Merge branch 'master' into local-react-native-cli

b700d39


          Fix code after merging

cc8b72b


          Remove node launcher

a4bcfb3

SounD120 suggested changes

View reviewed changes

src/common/commandExecutor.ts Outdated Show resolved Hide resolved

src/common/commandExecutor.ts Outdated Show resolved Hide resolved

src/common/commandExecutor.ts Outdated Show resolved Hide resolved

src/common/commandExecutor.ts Outdated Show resolved Hide resolved

src/extension/rn-extension.ts Outdated Show resolved Hide resolved

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

RedMickey added 6 commits

September 3, 2019 18:46


          Change getting version errors handler

bed2436


          Fix code style

2b740aa


          Add customReactNativeCLIPath parameter to debug options

3db6ba0


          Add reactNativeGlobalCommandName parameter to debug options

dd1ae57


          Add test for commandExecutor getReactNativeVersion func

a2465ec


          Move reactNativeGlobalCommandName from launch.json to settings.json

512ea48

dhanvikapila reviewed

View reviewed changes

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

src/extension/commandPaletteHandler.ts Outdated Show resolved Hide resolved

src/common/commandExecutor.ts Outdated Show resolved Hide resolved

src/extension/settingsHelper.ts Outdated Show resolved Hide resolved

RedMickey and others added 9 commits

September 17, 2019 12:57


          Remove redundant conditional statements

d064be5


          Merge branch 'master' into local-react-native-cli

87943d6


          Merge branch 'master' into local-react-native-cli

f997f25


          Create global CLI smoke tests

dc1b5d3


          Little fix

cba9ccf


          Remove smoke tests for global RN CLI

6fc0456


          Add unit tests for CLI select function

799818b


          Little code style fix

fc8bcfc


          Add React Native 0.61 project

d23cbc3

SounD120 suggested changes

View reviewed changes

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

test/smoke/resources/settings.json Outdated Show resolved Hide resolved

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

SounD120 and others added 3 commits

October 2, 2019 15:09


          Merge branch 'master' into local-react-native-cli

e60874e


          Change telemetry event name and add unit tests for local/global cli

99f89a6


          Merge branch 'local-react-native-cli' of https://github.com/RedMickey…

bf86322

…/vscode-react-native into local-react-native-cli

SounD120 reviewed

View reviewed changes

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

test/extension/commandExecutor.test.ts Show resolved Hide resolved

SounD120 reviewed

View reviewed changes

src/extension/extensionServer.ts Outdated Show resolved Hide resolved

RedMickey added 3 commits

October 21, 2019 10:14


          Refactoring getting React Native version from node_modules

31f3028


          Add unit tests for ReactNativeProjectHelper

f110e6d


          Roll back several previous changes and adapt unit tests

9ce5cd2

SounD120 reviewed

View reviewed changes

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

src/common/reactNativeProjectHelper.ts Outdated Show resolved Hide resolved

SounD120 and others added 3 commits

October 21, 2019 14:51


          Merge branch 'master' into local-react-native-cli

affad3b


          Add more unit tests for ReactNativeProjectHelper

6a3901f


          Merge branch 'local-react-native-cli' of https://github.com/RedMickey…

4edb3ed

…/vscode-react-native into local-react-native-cli

SounD120 reviewed

View reviewed changes

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

RedMickey added 2 commits

October 21, 2019 16:37


          Change hash generation

e622a5c


          Minor fix

727168d

SounD120 reviewed

View reviewed changes

test/common/reactNativeProjectHelper.test.ts Outdated Show resolved Hide resolved

test/common/reactNativeProjectHelper.test.ts Outdated Show resolved Hide resolved

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

test/extension/commandExecutor.test.ts Outdated Show resolved Hide resolved

test/common/reactNativeProjectHelper.test.ts Outdated Show resolved Hide resolved

test/common/reactNativeProjectHelper.test.ts Outdated Show resolved Hide resolved

SounD120 reviewed

View reviewed changes

src/extension/settingsHelper.ts Outdated Show resolved Hide resolved


          Fix review comments

99a5aff

Co-Authored-By: Yuri Skorokhodov <[email protected]>

SounD120 reviewed

View reviewed changes

test/common/reactNativeProjectHelper.test.ts Outdated Show resolved Hide resolved


          Merge branch 'master' into local-react-native-cli

3b25d44

SounD120 requested review from SounD120 and dhanvikapila

October 22, 2019 11:28

RedMickey added 2 commits

October 22, 2019 14:35


          Minor test description fix

2ef6bd8


          Merge branch 'local-react-native-cli' of https://github.com/RedMickey…

515804f

…/vscode-react-native into local-react-native-cli

SounD120 approved these changes

View reviewed changes

dhanvikapila reviewed

View reviewed changes

src/common/reactNativeProjectHelper.ts Show resolved Hide resolved

dhanvikapila reviewed

View reviewed changes

src/common/commandExecutor.ts Show resolved Hide resolved

dhanvikapila reviewed

View reviewed changes

Member

dhanvikapila left a comment

Looks good.
Got some small questions in my review.

SounD120 and others added 3 commits

October 24, 2019 14:44


          Merge branch 'master' into local-react-native-cli

17493e9


          Minor fix

b2c22ce


          Merge branch 'local-react-native-cli' of https://github.com/RedMickey…

0166d70

…/vscode-react-native into local-react-native-cli

RedMickey merged commit af1474a into microsoft:master

RedMickey deleted the local-react-native-cli branch

October 25, 2019 09:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet