Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'program' debug configuration property #1039

Merged
merged 14 commits into from
Jun 28, 2019

Conversation

SounD120
Copy link
Contributor

@SounD120 SounD120 commented Jun 27, 2019

This PR will deprecate program debug configuration property. Users that still use this property will see the following message in their debug console:
image

${workspaceRoot} was renamed to ${workspaceFolder} due to this recommendation.

AB#689

@SounD120 SounD120 changed the title Remove debug program property Remove debug configuration 'program' property Jun 27, 2019
@ruslan-bikkinin ruslan-bikkinin changed the title Remove debug configuration 'program' property Deprecate debug configuration 'program' property Jun 27, 2019
@ruslan-bikkinin ruslan-bikkinin changed the title Deprecate debug configuration 'program' property Deprecate 'program' debug configuration property Jun 27, 2019
@ruslan-bikkinin
Copy link
Contributor

@SounD120 please, also, update configurations in smoke tests.

@SounD120
Copy link
Contributor Author

Sure, I want to make sure that both "program" and "cwd" parameters will work correctly.

@SounD120 SounD120 marked this pull request as ready for review June 27, 2019 17:43
package.nls.json Outdated Show resolved Hide resolved
package.nls.json Show resolved Hide resolved
src/debugger/nodeDebugWrapper.ts Outdated Show resolved Hide resolved
@SounD120 SounD120 merged commit 18ea7d1 into master Jun 28, 2019
@SounD120 SounD120 deleted the remove-debug-program-property branch June 28, 2019 10:05
@SounD120 SounD120 restored the remove-debug-program-property branch June 28, 2019 10:05
@SounD120 SounD120 deleted the remove-debug-program-property branch June 28, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants