-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate 'program' debug configuration property #1039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SounD120
changed the title
Remove debug program property
Remove debug configuration 'program' property
Jun 27, 2019
ruslan-bikkinin
changed the title
Remove debug configuration 'program' property
Deprecate debug configuration 'program' property
Jun 27, 2019
ruslan-bikkinin
changed the title
Deprecate debug configuration 'program' property
Deprecate 'program' debug configuration property
Jun 27, 2019
@SounD120 please, also, update configurations in smoke tests. |
Sure, I want to make sure that both "program" and "cwd" parameters will work correctly. |
…crosoft/vscode-react-native into remove-debug-program-property
Co-Authored-By: Ruslan Bikkinin <[email protected]>
SounD120
commented
Jun 28, 2019
SounD120
commented
Jun 28, 2019
ruslan-bikkinin
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will deprecate
program
debug configuration property. Users that still use this property will see the following message in their debug console:${workspaceRoot}
was renamed to${workspaceFolder}
due to this recommendation.AB#689