Add Hermes Expo debugger in debug-alt menu (#1942)

microsoft · Apr 12, 2023 · 0b86204 · 0b86204
1 parent 83879a3
commit 0b86204
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 0 deletions.
diff --git a/package.json b/package.json
@@ -305,6 +305,13 @@
         "enablement": "!config.security.workspace.trust.enabled && !inDebugMode || isWorkspaceTrusted && !inDebugMode",
         "icon": "$(debug-alt)"
       },
+      {
+        "command": "reactNative.debugScenario.debugInHermesExponentExperimental",
+        "title": "Debug in Hermes Exponent - Experimental",
+        "category": "React Native",
+        "enablement": "!config.security.workspace.trust.enabled && !inDebugMode || isWorkspaceTrusted && !inDebugMode",
+        "icon": "$(debug-alt)"
+      },
       {
         "command": "reactNative.debugScenario.debugAndroidHermesExperimental",
         "title": "Debug Android Hermes - Experimental",
@@ -410,6 +417,10 @@
           "command": "reactNative.debugScenario.debugInExponent",
           "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
         },
+        {
+          "command": "reactNative.debugScenario.debugInHermesExponentExperimental",
+          "when": "isRNProject && config.react-native-tools.displayDebuggingCommandsButton"
+        },
         {
           "command": "reactNative.debugScenario.debugAndroidHermesExperimental",
           "when": "isRNProject && isRNAndroidHermesProject && config.react-native-tools.displayDebuggingCommandsButton"
@@ -488,6 +499,10 @@
           "command": "reactNative.debugScenario.debugInExponent",
           "when": "false"
         },
+        {
+          "command": "reactNative.debugScenario.debugInHermesExponentExperimental",
+          "when": "false"
+        },
         {
           "command": "reactNative.debugScenario.debugAndroidHermesExperimental",
           "when": "false"

diff --git a/src/extension/commands/debugScenario.ts b/src/extension/commands/debugScenario.ts
@@ -153,6 +153,23 @@ export class DebugInExponent extends Command {
     }
 }
 
+export class DebugInHermesExponent extends Command {
+    codeName = "debugScenario.debugInHermesExponentExperimental";
+    label = "";
+    error = ErrorHelper.getInternalError(
+        InternalErrorCode.DebuggingCommandFailed,
+        DEBUG_CONFIGURATION_NAMES.DEBUG_IN_EXPONENT_HERMES_EXPERIMENTAL,
+    );
+
+    async baseFn(): Promise<void> {
+        assert(this.project);
+        startDebug(
+            debugConfigurations[DEBUG_CONFIGURATION_NAMES.DEBUG_IN_EXPONENT_HERMES_EXPERIMENTAL],
+            this.project,
+        );
+    }
+}
+
 export class DebugAndroidHermesExperimental extends Command {
     codeName = "debugScenario.debugAndroidHermesExperimental";
     label = "";

diff --git a/src/extension/debuggingConfiguration/reactNativeDebugConfigProvider.ts b/src/extension/debuggingConfiguration/reactNativeDebugConfigProvider.ts
@@ -65,6 +65,13 @@ export class ReactNativeDebugConfigProvider implements vscode.DebugConfiguration
                 "Debug Expo application or React Native application in Expo",
             ),
         },
+        {
+            label: DEBUG_CONFIGURATION_NAMES.DEBUG_IN_EXPONENT_HERMES_EXPERIMENTAL,
+            description: localize(
+                "DebugHermesExpoConfigDesc",
+                "Debug Hermes Expo application or React Native application in Expo",
+            ),
+        },
         {
             label: DEBUG_CONFIGURATION_NAMES.DEBUG_ANDROID_HERMES,
             description: localize(