Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the terminal activation experiment #9937

Merged

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 6, 2020

Disable until next release of VSC (for hidden terminals).
Disabled because a terminal gets displayed to the user and then hidden (doesn't happen in insiders, we will need to wait for their new API to hide terms)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 6, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #9937 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9937      +/-   ##
=========================================
- Coverage   61.21%   61.2%   -0.02%     
=========================================
  Files         564     564              
  Lines       30063   30063              
  Branches     4546    4546              
=========================================
- Hits        18404   18399       -5     
- Misses      10629   10633       +4     
- Partials     1030    1031       +1
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4458703...f868c85. Read the comment docs.

@DonJayamanne DonJayamanne merged commit c4967cb into microsoft:master Feb 6, 2020
@DonJayamanne DonJayamanne deleted the disableTerminalExperiment branch February 6, 2020 00:27
DonJayamanne added a commit that referenced this pull request Feb 6, 2020
Disable until next release of VSC (for hidden terminals).
Disabled because a terminal gets displayed to the user and then hidden (doesn't happen in insiders, we will need to wait for their new API to hide terms)
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants