Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable explorer when restarting a kernel #9931

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 5, 2020

For #9740

Make sure to clear variables when restarting (or switching) a kernel.

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #9931 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9931   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files         564      564           
  Lines       30061    30061           
  Branches     4545     4545           
=======================================
  Hits        18403    18403           
  Misses      10629    10629           
  Partials     1029     1029

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b7694...27830ac. Read the comment docs.

@rchiodo rchiodo merged commit 7d1b49a into master Feb 6, 2020
@rchiodo rchiodo deleted the rchiodo/fix_variable_reset branch February 6, 2020 00:08
rchiodo added a commit that referenced this pull request Feb 6, 2020
* Make sure to clear variable list on reset

* Add news entry
rchiodo added a commit that referenced this pull request Feb 6, 2020
* Fix variable explorer when restarting a kernel (#9931)

* Make sure to clear variable list on reset

* Add news entry

* Update changelog

* Update changelog
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants