Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Davidkutu/ds interactive window focus fix #9895

Merged
merged 7 commits into from
Feb 4, 2020

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Feb 4, 2020
@karthiknadig
Copy link
Member

karthiknadig commented Feb 4, 2020

If you already updated the change log then there is no need for a bug#.md file. That will duplicate the entries when we generate the change log.

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #9895 into release-2020.02 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-2020.02    #9895   +/-   ##
================================================
  Coverage            61.22%   61.22%           
================================================
  Files                  563      563           
  Lines                30058    30058           
  Branches              4545     4545           
================================================
  Hits                 18403    18403           
  Misses               10626    10626           
  Partials              1029     1029

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08b501...e125e89. Read the comment docs.

@DavidKutu
Copy link
Author

@karthiknadig Done

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidKutu DavidKutu merged commit f7ad067 into release-2020.02 Feb 4, 2020
@DavidKutu DavidKutu deleted the davidkutu/DSInteractiveWindowFocusFix branch February 4, 2020 18:54
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants