Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable webHostNotebook experiment and fix name of exp #9894

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

DonJayamanne
Copy link

  • Disable an experiment
  • Fix name of an existing experiment

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 4, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #9894 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9894      +/-   ##
==========================================
- Coverage   61.22%   61.21%   -0.02%     
==========================================
  Files         563      563              
  Lines       30058    30058              
  Branches     4545     4545              
==========================================
- Hits        18403    18399       -4     
- Misses      10626    10629       +3     
- Partials     1029     1030       +1
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcdb57...9bf7c3e. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 9f115a6 into microsoft:master Feb 4, 2020
@DonJayamanne DonJayamanne deleted the disableExperiment branch February 4, 2020 19:01
DonJayamanne added a commit that referenced this pull request Feb 4, 2020
Disable an experiment
Fix name of an existing experiment
DonJayamanne added a commit that referenced this pull request Feb 5, 2020
Disable an experiment
Fix name of an existing experiment
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants