Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the experiment check while getting remote debugger arguments. #8808

Merged
merged 2 commits into from
Nov 28, 2019

Conversation

karthiknadig
Copy link
Member

For #8685

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Unit tests & system/integration tests are added/updated
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 26, 2019
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #8808 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8808      +/-   ##
==========================================
- Coverage   58.66%   58.66%   -0.01%     
==========================================
  Files         526      526              
  Lines       27180    27179       -1     
  Branches     4044     4044              
==========================================
- Hits        15946    15945       -1     
  Misses      10363    10363              
  Partials      871      871
Impacted Files Coverage Δ
src/client/api.ts 92.85% <100%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57df230...67aecd7. Read the comment docs.

Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karthiknadig karthiknadig marked this pull request as ready for review November 27, 2019 22:37
@karthiknadig karthiknadig merged commit ee745a2 into microsoft:master Nov 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
@karthiknadig karthiknadig deleted the issue8685a branch December 27, 2019 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants