Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Run All" CodeLens for parametrized tests #8682

Closed

Conversation

phloose
Copy link

@phloose phloose commented Nov 20, 2019

Related to #5608.

This pull request aims to add a third code lens for running all parametrized tests that belong to a test function/method. Unlike suggested in the mentioned issue i found it more practical to not add the "Run All" option in the dropdown/picker. If one wants to run all parametrized tests that belong to a specific test he or she needs to only click this codelens and not click on run/debug test and then select that option from the dropdown/picker. So the usecase is more that one is able to select specific test with the first two codelenses that lets you select which specific test you want to run or debug, and to test if all of those parametrized tests run click on "Run All".

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented Nov 20, 2019

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #8682 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8682      +/-   ##
==========================================
- Coverage   59.17%   59.16%   -0.02%     
==========================================
  Files         521      521              
  Lines       23981    23987       +6     
  Branches     3874     3875       +1     
==========================================
+ Hits        14190    14191       +1     
- Misses       8874     8879       +5     
  Partials      917      917
Impacted Files Coverage Δ
src/client/testing/codeLenses/testFiles.ts 17.43% <ø> (ø) ⬆️
src/client/testing/main.ts 15.38% <0%> (-0.31%) ⬇️
src/client/common/constants.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664d8a9...77aebc2. Read the comment docs.

@phloose
Copy link
Author

phloose commented Nov 23, 2019

Closing in favor of #8757

@phloose phloose closed this Nov 23, 2019
@phloose phloose changed the title WIP: Add "Run All" CodeLens for parametrized tests Add "Run All" CodeLens for parametrized tests Nov 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants